Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DLI): import DLI template flink resource and add unit test and document. #1035

Merged
merged 1 commit into from
Nov 21, 2023
Merged

feat(DLI): import DLI template flink resource and add unit test and document. #1035

merged 1 commit into from
Nov 21, 2023

Conversation

Zippo-Wang
Copy link
Contributor

@Zippo-Wang Zippo-Wang commented Oct 11, 2023 •
edited
Loading

Attention：This PR is not complete yet. 2023/10/28

What this PR does / why we need it:
import resource_flexibleengine_dli_template_flink resource, unit test and document

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

=== RUN   TestAccFlinkTemplate_basic
=== PAUSE TestAccFlinkTemplate_basic
=== CONT  TestAccFlinkTemplate_basic
--- PASS: TestAccFlinkTemplate_basic (118.93s)
PASS
coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

=== RUN   TestAccDatasourceConnection_basic
=== PAUSE TestAccDatasourceConnection_basic
=== CONT  TestAccDatasourceConnection_basic
--- PASS: TestAccDatasourceConnection_basic (343.10s)
PASS

=== RUN   TestAccResourceDliSqlJob_basic
=== PAUSE TestAccResourceDliSqlJob_basic
=== CONT  TestAccResourceDliSqlJob_basic
--- PASS: TestAccResourceDliSqlJob_basic (109.02s)
PASS

coverage: 2.7% of statements in ../../../terraform-provider-flexibleengine/...

@Zippo-Wang Zippo-Wang changed the title feat(DLI): import dli_template_flink resource of DLI service and add … feat(DLI): import DLI template flink resource and add unit test and document. Oct 11, 2023
@Zippo-Wang Zippo-Wang force-pushed the migrate_DLI-dli_template_flink branch from dba2ab8 to 687d081 Compare October 11, 2023 06:52
@chengxiangdong
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Oct 16, 2023
@Zippo-Wang Zippo-Wang force-pushed the migrate_DLI-dli_template_flink branch from 687d081 to 68fc0ca Compare October 19, 2023 02:27
@github-actions github-actions bot removed the LGTM label Oct 19, 2023
@chengxiangdong
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Oct 19, 2023
@Zippo-Wang Zippo-Wang force-pushed the migrate_DLI-dli_template_flink branch from 68fc0ca to d579728 Compare October 27, 2023 02:20
@Zippo-Wang Zippo-Wang force-pushed the migrate_DLI-dli_template_flink branch from d579728 to 3fe5dcf Compare October 28, 2023 06:13
@github-actions github-actions bot added size/L and removed size/M labels Oct 28, 2023
@Zippo-Wang Zippo-Wang force-pushed the migrate_DLI-dli_template_flink branch 2 times, most recently from 7da877d to a4b354e Compare October 28, 2023 06:34
@Zippo-Wang Zippo-Wang force-pushed the migrate_DLI-dli_template_flink branch 2 times, most recently from fbe9d6f to 850731b Compare November 3, 2023 07:13
@chengxiangdong
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Nov 7, 2023
@Zippo-Wang Zippo-Wang force-pushed the migrate_DLI-dli_template_flink branch from 850731b to 5ba7eb9 Compare November 9, 2023 06:44
@Zippo-Wang Zippo-Wang force-pushed the migrate_DLI-dli_template_flink branch from 5ba7eb9 to 849e7dd Compare November 9, 2023 06:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@Zippo-Wang Zippo-Wang force-pushed the migrate_DLI-dli_template_flink branch from 849e7dd to bec47c1 Compare November 9, 2023 06:52
@Zippo-Wang Zippo-Wang force-pushed the migrate_DLI-dli_template_flink branch 2 times, most recently from a6d6cae to 4337122 Compare November 9, 2023 07:04
@Zippo-Wang Zippo-Wang force-pushed the migrate_DLI-dli_template_flink branch from 4337122 to bcbc69f Compare November 10, 2023 02:25
@chengxiangdong
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Nov 21, 2023
@ShiChangkuo ShiChangkuo merged commit c74a7eb into FlexibleEngineCloud:master Nov 21, 2023
5 checks passed
@Zippo-Wang Zippo-Wang deleted the migrate_DLI-dli_template_flink branch November 22, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature LGTM size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zippo-Wang @chengxiangdong @ShiChangkuo